diff --git a/Makefile b/Makefile --- a/Makefile +++ b/Makefile @@ -164,6 +164,9 @@ osx: --root=build/mercurial/ --prefix=/usr/local/ \ --install-lib=/Library/Python/2.7/site-packages/ make -C doc all install DESTDIR="$(PWD)/build/mercurial/" + # Place a bogon .DS_Store file in the target dir so we can be + # sure it doesn't get included in the final package. + touch build/mercurial/.DS_Store # install zsh completions - this location appears to be # searched by default as of macOS Sierra. install -d build/mercurial/usr/local/share/zsh/site-functions/ @@ -177,7 +180,7 @@ osx: mkdir -p $${OUTPUTDIR:-dist} HGVER=$$((cat build/mercurial/Library/Python/2.7/site-packages/mercurial/__version__.py; echo 'print(version)') | python) && \ OSXVER=$$(sw_vers -productVersion | cut -d. -f1,2) && \ - pkgbuild --root build/mercurial/ \ + pkgbuild --filter \\.DS_Store --root build/mercurial/ \ --identifier org.mercurial-scm.mercurial \ --version "$${HGVER}" \ build/mercurial.pkg && \ diff --git a/tests/test-mac-packages.t b/tests/test-mac-packages.t --- a/tests/test-mac-packages.t +++ b/tests/test-mac-packages.t @@ -18,6 +18,11 @@ Gather list of all installed files: $ lsbom mercurial.pkg/Bom > boms.txt +We've had problems with the filter logic in the past. Make sure no +.DS_Store files ended up in the final package: + $ grep DS_S boms.txt + [1] + Spot-check some randomly selected files: $ grep bdiff boms.txt | cut -d ' ' -f 1,2,3 ./Library/Python/2.7/site-packages/mercurial/bdiff.so 100755 0/0