diff --git a/contrib/check-code.py b/contrib/check-code.py --- a/contrib/check-code.py +++ b/contrib/check-code.py @@ -53,7 +53,8 @@ def compilere(pat, multiline=False): def repquote(m): # check "rules depending on implementation of repquote()" in each # patterns (especially pypats), before changing this function - fixedmap = {' ': ' ', '\n': '\n', '.': 'p', ':': 'q'} + fixedmap = {' ': ' ', '\n': '\n', '.': 'p', ':': 'q', + '%': '%', '\\': 'b', '*': 'A', '+': 'P', '-': 'M'} def encodechr(i): if i > 255: return 'u' @@ -326,7 +327,8 @@ pypats = [ (r'\.next\(\)', "don't use .next(), use next(...)"), # rules depending on implementation of repquote() - (r' x+[xpqo][\'"]\n\s+[\'"]x', 'string join across lines with no space'), + (r' x+[xpqo%APM][\'"]\n\s+[\'"]x', + 'string join across lines with no space'), (r'ui\.(status|progress|write|note|warn)\([\'\"]x', "missing _() in ui message (use () to hide false-positives)"), ], diff --git a/tests/test-contrib-check-code.t b/tests/test-contrib-check-code.t --- a/tests/test-contrib-check-code.t +++ b/tests/test-contrib-check-code.t @@ -256,6 +256,10 @@ web templates > 'bar foo.' > 'bar foo:' > 'bar foo@' + > 'bar foo%' + > 'bar foo*' + > 'bar foo+' + > 'bar foo-' > 'bar') > EOF $ "$check_code" stringjoin.py @@ -271,4 +275,16 @@ web templates stringjoin.py:4: > 'bar foo@' string join across lines with no space + stringjoin.py:5: + > 'bar foo%' + string join across lines with no space + stringjoin.py:6: + > 'bar foo*' + string join across lines with no space + stringjoin.py:7: + > 'bar foo+' + string join across lines with no space + stringjoin.py:8: + > 'bar foo-' + string join across lines with no space [1]