diff --git a/mercurial/revlog.py b/mercurial/revlog.py --- a/mercurial/revlog.py +++ b/mercurial/revlog.py @@ -438,7 +438,7 @@ class revlog(object): if l >= 0: return l - t = self.revision(self.node(rev)) + t = self.revision(rev) return len(t) size = rawsize @@ -1596,7 +1596,7 @@ class revlog(object): fh = ifh else: fh = dfh - basetext = self.revision(self.node(baserev), _df=fh, raw=raw) + basetext = self.revision(baserev, _df=fh, raw=raw) btext[0] = mdiff.patch(basetext, delta) try: @@ -1628,7 +1628,7 @@ class revlog(object): fh = ifh else: fh = dfh - ptext = self.revision(self.node(rev), _df=fh) + ptext = self.revision(rev, _df=fh) delta = mdiff.textdiff(ptext, t) header, data = self.compress(delta) deltalen = len(header) + len(data) diff --git a/tests/test-check-code.t b/tests/test-check-code.t --- a/tests/test-check-code.t +++ b/tests/test-check-code.t @@ -45,15 +45,6 @@ New errors are not allowed. Warnings are mercurial/policy.py:49: > policy = os.environ.get('HGMODULEPOLICY', policy) use encoding.environ instead (py3) - mercurial/revlog.py:441: - > t = self.revision(self.node(rev)) - don't covert rev to node before passing to revision(nodeorrev) - mercurial/revlog.py:1599: - > basetext = self.revision(self.node(baserev), _df=fh, raw=raw) - don't covert rev to node before passing to revision(nodeorrev) - mercurial/revlog.py:1631: - > ptext = self.revision(self.node(rev), _df=fh) - don't covert rev to node before passing to revision(nodeorrev) Skipping mercurial/statprof.py it has no-che?k-code (glob) mercurial/unionrepo.py:93: > return mdiff.textdiff(self.revision(self.node(rev1)),