diff --git a/mercurial/logcmdutil.py b/mercurial/logcmdutil.py
--- a/mercurial/logcmdutil.py
+++ b/mercurial/logcmdutil.py
@@ -800,7 +800,7 @@ def _makenofollowfilematcher(repo, pats,
 }
 
 
-def _makerevset(repo, match, pats, slowpath, opts):
+def _makerevset(repo, pats, slowpath, opts):
     """Return a revset string built from log options and file patterns"""
     opts = dict(opts)
     # follow or not follow?
@@ -896,7 +896,7 @@ def getrevs(repo, pats, opts):
         def filematcher(ctx):
             return match
 
-    expr = _makerevset(repo, match, pats, slowpath, opts)
+    expr = _makerevset(repo, pats, slowpath, opts)
     if opts.get(b'graph'):
         if repo.ui.configbool(b'experimental', b'log.topo'):
             if not revs.istopo():
diff --git a/tests/printrevset.py b/tests/printrevset.py
--- a/tests/printrevset.py
+++ b/tests/printrevset.py
@@ -16,7 +16,7 @@ def logrevset(repo, pats, opts):
     if not revs:
         return None
     match, pats, slowpath = logcmdutil._makematcher(repo, revs, pats, opts)
-    return logcmdutil._makerevset(repo, match, pats, slowpath, opts)
+    return logcmdutil._makerevset(repo, pats, slowpath, opts)
 
 
 def uisetup(ui):