diff --git a/hgext/largefiles/lfcommands.py b/hgext/largefiles/lfcommands.py --- a/hgext/largefiles/lfcommands.py +++ b/hgext/largefiles/lfcommands.py @@ -268,6 +268,7 @@ def _commitcontext(rdst, parents, ctx, d mctx = context.memctx(rdst, parents, ctx.description(), dstfiles, getfilectx, ctx.user(), ctx.date(), ctx.extra()) ret = rdst.commitctx(mctx) + lfutil.copyalltostore(rdst, ret) rdst.setparents(ret) revmap[ctx.node()] = rdst.changelog.tip() diff --git a/hgext/largefiles/lfutil.py b/hgext/largefiles/lfutil.py --- a/hgext/largefiles/lfutil.py +++ b/hgext/largefiles/lfutil.py @@ -204,7 +204,7 @@ def copyalltostore(repo, node): def copytostoreabsolute(repo, file, hash): if inusercache(repo.ui, hash): link(usercachepath(repo.ui, hash), storepath(repo, hash)) - elif not getattr(repo, "_isconverting", False): + else: util.makedirs(os.path.dirname(storepath(repo, hash))) dst = util.atomictempfile(storepath(repo, hash), createmode=repo.store.createmode) @@ -408,6 +408,9 @@ def markcommitted(orig, ctx, node): synclfdirstate(repo, lfdirstate, lfile, False) lfdirstate.write() + # As part of committing, copy all of the largefiles into the cache. + copyalltostore(repo, node) + def getlfilestoupdate(oldstandins, newstandins): changedstandins = set(oldstandins).symmetric_difference(set(newstandins)) filelist = [] diff --git a/hgext/largefiles/overrides.py b/hgext/largefiles/overrides.py --- a/hgext/largefiles/overrides.py +++ b/hgext/largefiles/overrides.py @@ -1226,14 +1226,6 @@ def overridecat(orig, ui, repo, file1, * err = 0 return err -def mercurialsinkbefore(orig, sink): - sink.repo._isconverting = True - orig(sink) - -def mercurialsinkafter(orig, sink): - sink.repo._isconverting = False - orig(sink) - def mergeupdate(orig, repo, node, branchmerge, force, partial, *args, **kwargs): wlock = repo.wlock() diff --git a/hgext/largefiles/reposetup.py b/hgext/largefiles/reposetup.py --- a/hgext/largefiles/reposetup.py +++ b/hgext/largefiles/reposetup.py @@ -241,11 +241,8 @@ def reposetup(ui, repo): self.lfstatus = True return scmutil.status(*result) - # As part of committing, copy all of the largefiles into the - # cache. def commitctx(self, ctx, *args, **kwargs): node = super(lfilesrepo, self).commitctx(ctx, *args, **kwargs) - lfutil.copyalltostore(self, node) class lfilesctx(ctx.__class__): def markcommitted(self, node): orig = super(lfilesctx, self).markcommitted diff --git a/hgext/largefiles/uisetup.py b/hgext/largefiles/uisetup.py --- a/hgext/largefiles/uisetup.py +++ b/hgext/largefiles/uisetup.py @@ -174,10 +174,3 @@ def uisetup(ui): if name == 'transplant': extensions.wrapcommand(getattr(module, 'cmdtable'), 'transplant', overrides.overridetransplant) - if name == 'convert': - convcmd = getattr(module, 'convcmd') - hgsink = getattr(convcmd, 'mercurial_sink') - extensions.wrapfunction(hgsink, 'before', - overrides.mercurialsinkbefore) - extensions.wrapfunction(hgsink, 'after', - overrides.mercurialsinkafter) diff --git a/tests/test-largefiles-update.t b/tests/test-largefiles-update.t --- a/tests/test-largefiles-update.t +++ b/tests/test-largefiles-update.t @@ -611,3 +611,16 @@ the working context) #endif $ cd .. + +Test that "hg convert" avoids copying largefiles from the working +directory into store, because "hg convert" doesn't update largefiles +in the working directory (removing files under ".cache/largefiles" +forces "hg convert" to copy corresponding largefiles) + + $ cat >> $HGRCPATH < [extensions] + > convert = + > EOF + + $ rm $TESTTMP/.cache/largefiles/6a4f36d4075fbe0f30ec1d26ca44e63c05903671 + $ hg convert -q repo repo.converted