diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py --- a/mercurial/scmutil.py +++ b/mercurial/scmutil.py @@ -950,6 +950,7 @@ class filecache(object): def __get__(self, obj, type=None): # do we need to check if the file changed? if self.name in obj.__dict__: + assert self.name in obj._filecache, self.name return obj.__dict__[self.name] entry = obj._filecache.get(self.name) @@ -971,8 +972,15 @@ class filecache(object): return entry.obj def __set__(self, obj, value): - if self.name in obj._filecache: - obj._filecache[self.name].obj = value # update cached copy + if self.name not in obj._filecache: + # we add an entry for the missing value because X in __dict__ + # implies X in _filecache + ce = filecacheentry(self.join(obj, self.path), False) + obj._filecache[self.name] = ce + else: + ce = obj._filecache[self.name] + + ce.obj = value # update cached copy obj.__dict__[self.name] = value # update copy returned by obj.x def __delete__(self, obj): diff --git a/tests/test-filecache.py b/tests/test-filecache.py --- a/tests/test-filecache.py +++ b/tests/test-filecache.py @@ -101,6 +101,17 @@ def test_filecache_synced(): # it repo.commit('.') +def setbeforeget(repo): + os.remove('x') + repo.cached = 0 + repo.invalidate() + print repo.cached + repo.invalidate() + f = open('x', 'w') + f.write('a') + f.close() + print repo.cached + print 'basic:' print basic(fakerepo()) @@ -109,3 +120,7 @@ print 'fakeuncacheable:' print fakeuncacheable() test_filecache_synced() +print +print 'setbeforeget:' +print +setbeforeget(fakerepo()) diff --git a/tests/test-filecache.py.out b/tests/test-filecache.py.out --- a/tests/test-filecache.py.out +++ b/tests/test-filecache.py.out @@ -17,3 +17,9 @@ repository tip rolled back to revision - working directory now based on revision -1 repository tip rolled back to revision -1 (undo commit) working directory now based on revision -1 + +setbeforeget: + +0 +creating +None