# HG changeset patch # User Pierre-Yves David # Date 2020-04-14 01:20:21 # Node ID 059c99af141d3fd6387aa1388e4fb36760d5f746 # Parent 3cfcbb2194964f84b7f8ebdb5c6dfe2d452a3678 nodemap: move the option for mmap usage to storage.revlog.nodemap.mmap The option is stay experimental as long as the main feature is. Differential Revision: https://phab.mercurial-scm.org/D8421 diff --git a/mercurial/configitems.py b/mercurial/configitems.py --- a/mercurial/configitems.py +++ b/mercurial/configitems.py @@ -663,9 +663,6 @@ coreconfigitem( b'experimental', b'rust.index', default=False, ) coreconfigitem( - b'experimental', b'exp-persistent-nodemap.mmap', default=True, -) -coreconfigitem( b'experimental', b'exp-persistent-nodemap.mode', default=b'compat', ) coreconfigitem( @@ -1082,6 +1079,10 @@ coreconfigitem( default=True, alias=[(b'format', b'aggressivemergedeltas')], ) +# experimental as long as rust is experimental (or a C version is implemented) +coreconfigitem( + b'storage', b'revlog.nodemap.mmap', default=True, experimental=True +) coreconfigitem( b'storage', b'revlog.reuse-external-delta', default=True, ) diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py --- a/mercurial/localrepo.py +++ b/mercurial/localrepo.py @@ -938,7 +938,7 @@ def resolverevlogstorevfsoptions(ui, req options[b'rust.index'] = True if NODEMAP_REQUIREMENT in requirements: options[b'persistent-nodemap'] = True - if ui.configbool(b'experimental', b'exp-persistent-nodemap.mmap'): + if ui.configbool(b'storage', b'revlog.nodemap.mmap'): options[b'persistent-nodemap.mmap'] = True epnm = ui.config(b'experimental', b'exp-persistent-nodemap.mode') options[b'persistent-nodemap.mode'] = epnm diff --git a/tests/test-persistent-nodemap.t b/tests/test-persistent-nodemap.t --- a/tests/test-persistent-nodemap.t +++ b/tests/test-persistent-nodemap.t @@ -156,12 +156,12 @@ Test code path without mmap $ echo bar > bar $ hg add bar - $ hg ci -m 'bar' --config experimental.exp-persistent-nodemap.mmap=no + $ hg ci -m 'bar' --config storage.revlog.nodemap.mmap=no - $ hg debugnodemap --check --config experimental.exp-persistent-nodemap.mmap=yes + $ hg debugnodemap --check --config storage.revlog.nodemap.mmap=yes revision in index: 5003 revision in nodemap: 5003 - $ hg debugnodemap --check --config experimental.exp-persistent-nodemap.mmap=no + $ hg debugnodemap --check --config storage.revlog.nodemap.mmap=no revision in index: 5003 revision in nodemap: 5003