# HG changeset patch
# User Laurent Charignon <lcharignon@fb.com>
# Date 2015-08-01 12:43:39
# Node ID 0b57b77f9b3ed5c1cc24ce95173c4f7e824df13f
# Parent  5243890224ff3e1a68cfc3a83150cf2fb707af14

devel-warn: issue a warning when writing bookmarks without holding the wlock

I saw an issue in an extension that we develop where we were writing bookmarks
without holding the wlock. Another extension was taking a lock at the same time
and wiped out the bookmarks we were about to write. This patch adds a
devel-warning to urge people to fix their invalid code.

diff --git a/mercurial/bookmarks.py b/mercurial/bookmarks.py
--- a/mercurial/bookmarks.py
+++ b/mercurial/bookmarks.py
@@ -90,6 +90,11 @@ class bmstore(dict):
         can be copied back on rollback.
         '''
         repo = self._repo
+        if (repo.ui.configbool('devel', 'all-warnings')
+                or repo.ui.configbool('devel', 'check-locks')):
+            l = repo._wlockref and repo._wlockref()
+            if l is None or not l.held:
+                repo.ui.develwarn('bookmarks write with no wlock')
         self._writerepo(repo)
         repo.invalidatevolatilesets()