# HG changeset patch # User Danek Duvall # Date 2017-06-06 15:58:27 # Node ID 0c09afdf5704e48b70a4d57b47cbf0674962ec55 # Parent 0841382d114ae0c246cb5862c929fe16041f308c check-code: ban grep's context flags (-A/-B/-C) since they're not on Solaris diff --git a/contrib/check-code.py b/contrib/check-code.py --- a/contrib/check-code.py +++ b/contrib/check-code.py @@ -145,6 +145,7 @@ testpats = [ (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"), (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"), (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"), + (r'grep.* -[ABC] ', "don't use grep's context flags"), ], # warnings [