# HG changeset patch # User Siddharth Agarwal # Date 2014-03-21 02:38:17 # Node ID 0c32fafd4b3ba4b9eb799f95d44fdb52a27d96e1 # Parent 6a2acb0d9352d5be5c495ad332497ad60a19578e subrepo: convert matched string to integer before comparing Git version (1, '4') is greater than (1, 5) so the version check never actually worked. diff --git a/mercurial/subrepo.py b/mercurial/subrepo.py --- a/mercurial/subrepo.py +++ b/mercurial/subrepo.py @@ -1121,7 +1121,7 @@ class gitsubrepo(abstractsubrepo): if not m: self._ui.warn(_('cannot retrieve git version')) return - version = (int(m.group(1)), m.group(2)) + version = (int(m.group(1)), int(m.group(2))) # git 1.4.0 can't work at all, but 1.5.X can in at least some cases, # despite the docstring comment. For now, error on 1.4.0, warn on # 1.5.0 but attempt to continue.