# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 2024-12-06 04:58:28
# Node ID 0c4832bf517a53281745288206339883b66bdf46
# Parent  0851d94bfdaa50d13a09eac6f4833bb66401942d

contrib: propagate `pytype` failures outside of `check-pytype.sh`

A recent series got landed with a pytype failure, because it wasn't propagated
to the CI caller (see c47fe7fd312d).  I suspect it started recently with
069735062524, because failures have been flagged in the past.

The shebang line needs to be specific to bash, otherwise it ignores this
non-POSIX extension.  I'm not aware of a POSIX flavor of this option.

diff --git a/contrib/check-pytype.sh b/contrib/check-pytype.sh
--- a/contrib/check-pytype.sh
+++ b/contrib/check-pytype.sh
@@ -1,7 +1,8 @@
-#!/bin/sh
+#!/bin/bash
 
 set -e
 set -u
+set -o pipefail
 
 cd "$(hg root)"
 
diff --git a/contrib/heptapod-ci.yml b/contrib/heptapod-ci.yml
--- a/contrib/heptapod-ci.yml
+++ b/contrib/heptapod-ci.yml
@@ -442,7 +442,7 @@ check-pytype:
       - ./contrib/setup-pytype.sh
     script:
       - echo "Entering script section"
-      - sh contrib/check-pytype.sh
+      - bash contrib/check-pytype.sh
 
 # `sh.exe --login` sets a couple of extra environment variables that are defined
 # in the MinGW shell, but switches CWD to /home/$username.  The previous value