# HG changeset patch # User Benoit Boissinot # Date 2009-11-07 12:25:25 # Node ID 0c84afa1d622274e2e05b7534575c8b6cf293717 # Parent 245689e7f86959cfcd6e9bbdc5db27b5a92a52bc sshrepo: move mkstemp() out of the try block, we don't use the exception simpler fix for 3b6f18851d87 diff --git a/mercurial/sshserver.py b/mercurial/sshserver.py --- a/mercurial/sshserver.py +++ b/mercurial/sshserver.py @@ -181,11 +181,9 @@ class sshserver(object): self.respond('') # write bundle data to temporary file because it can be big - tempname = fp = None + fd, tempname = tempfile.mkstemp(prefix='hg-unbundle-') + fp = os.fdopen(fd, 'wb+') try: - fd, tempname = tempfile.mkstemp(prefix='hg-unbundle-') - fp = os.fdopen(fd, 'wb+') - count = int(self.fin.readline()) while count: fp.write(self.fin.read(count)) @@ -212,10 +210,8 @@ class sshserver(object): self.lock.release() self.lock = None finally: - if fp is not None: - fp.close() - if tempname is not None: - os.unlink(tempname) + fp.close() + os.unlink(tempname) def do_stream_out(self): try: