# HG changeset patch # User Boris Feld # Date 2018-06-05 18:47:52 # Node ID 160bd45cc6af78282b7e085fabf0546fbbc4569a # Parent fd7376fa60e7350d03fc257c9b609732a37c6284 phase: explicitly exclude secret phase and above The comment explicitly mention the secret phase so we should as well use that in the code. diff --git a/mercurial/phases.py b/mercurial/phases.py --- a/mercurial/phases.py +++ b/mercurial/phases.py @@ -586,7 +586,7 @@ def subsetphaseheads(repo, subset): headsbyphase = [[] for i in allphases] # No need to keep track of secret phase; any heads in the subset that # are not mentioned are implicitly secret. - for phase in allphases[:-1]: + for phase in allphases[:secret]: revset = "heads(%%ln & %s())" % phasenames[phase] headsbyphase[phase] = [cl.node(r) for r in repo.revs(revset, subset)] return headsbyphase