# HG changeset patch # User Ian Moody # Date 2019-03-08 22:26:43 # Node ID 16d050678047133bffbf161565586ee81bf39ae3 # Parent 634b56b54e7c15fd623893fdd4f26097122ac0f0 py3: use r'' for group name arguments to MatchObjects in phabricator.py MatchObject group names are strings, not bytes. Using bytes in py3 leads to an IndexError. Differential Revision: https://phab.mercurial-scm.org/D6111 diff --git a/hgext/phabricator.py b/hgext/phabricator.py --- a/hgext/phabricator.py +++ b/hgext/phabricator.py @@ -304,7 +304,7 @@ def getoldnodedrevmap(repo, nodelist): # Check commit message m = _differentialrevisiondescre.search(ctx.description()) if m: - toconfirm[node] = (1, set(precnodes), int(m.group(b'id'))) + toconfirm[node] = (1, set(precnodes), int(m.group(r'id'))) # Double check if tags are genuine by collecting all old nodes from # Phabricator, and expect precursors overlap with it. @@ -555,7 +555,7 @@ def phabsend(ui, repo, *revs, **opts): # Create a local tag to note the association, if commit message # does not have it already m = _differentialrevisiondescre.search(ctx.description()) - if not m or int(m.group(b'id')) != newrevid: + if not m or int(m.group(r'id')) != newrevid: tagname = b'D%d' % newrevid tags.tag(repo, tagname, ctx.node(), message=None, user=None, date=None, local=True) @@ -1001,8 +1001,8 @@ def template_review(context, mapping): m = _differentialrevisiondescre.search(ctx.description()) if m: return templateutil.hybriddict({ - b'url': m.group(b'url'), - b'id': b"D{}".format(m.group(b'id')), + b'url': m.group(r'url'), + b'id': b"D{}".format(m.group(r'id')), }) else: tags = ctx.repo().nodetags(ctx.node())