# HG changeset patch # User Augie Fackler # Date 2017-06-13 20:30:50 # Node ID 16ff5c6066a66971e1107dd74af1567f1414eb02 # Parent d3b2d4587e730883b02e60c997fb9f37f79d7217 patchbomb: look for non-empty publicurl, not a non-None one Otherwise it's impossible to turn this feature back off, which is making writing of tests awkward. diff --git a/hgext/patchbomb.py b/hgext/patchbomb.py --- a/hgext/patchbomb.py +++ b/hgext/patchbomb.py @@ -113,7 +113,7 @@ def _addpullheader(seq, ctx): # waiting for some logic that check that the changeset are available on the # destination before patchbombing anything. publicurl = repo.ui.config('patchbomb', 'publicurl') - if publicurl is not None: + if publicurl: return ('Available At %s\n' '# hg pull %s -r %s' % (publicurl, publicurl, ctx)) return None @@ -588,7 +588,7 @@ def email(ui, repo, *revs, **opts): # check if revision exist on the public destination publicurl = repo.ui.config('patchbomb', 'publicurl') - if publicurl is not None: + if publicurl: repo.ui.debug('checking that revision exist in the public repo') try: publicpeer = hg.peer(repo, {}, publicurl)