# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 2018-11-06 10:54:15
# Node ID 1d3bed7d292342de581a32b98a7176c010983fe0
# Parent  473510bf05750b4950978ce0c34f47a3af57fda7

procutil: import concerns about creationflags on Windows from D1701

I don't have the need anymore for the change in D1701 nor the time to
investigate the changes on all supported Windows platforms.

I import the stuff I learned on D1701 in the `runbgcommand` so the next people
working on it can starts from there.

Differential Revision: https://phab.mercurial-scm.org/D5229

diff --git a/mercurial/utils/procutil.py b/mercurial/utils/procutil.py
--- a/mercurial/utils/procutil.py
+++ b/mercurial/utils/procutil.py
@@ -474,6 +474,9 @@ if pycompat.iswindows:
     # https://msdn.microsoft.com/en-us/library/windows/desktop/ms684863.aspx
     # No stdlib constant exists for this value
     DETACHED_PROCESS = 0x00000008
+    # Following creation flags might create a console GUI window.
+    # Using subprocess.CREATE_NEW_CONSOLE might helps.
+    # See https://phab.mercurial-scm.org/D1701 for discussion
     _creationflags = DETACHED_PROCESS | subprocess.CREATE_NEW_PROCESS_GROUP
 
     def runbgcommand(script, env, shell=False, stdout=None, stderr=None):