# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 2020-07-18 09:13:41
# Node ID 211063648b29b1e7d9d5c9fbacd777b17c73f063
# Parent  f93a4e3d35ab4c241d00fe24ae858f8e9f727ad2

phases: fix error return with no exception from computephases()

PySet_Check() does not set an exception.

diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
--- a/mercurial/cext/revlog.c
+++ b/mercurial/cext/revlog.c
@@ -757,8 +757,11 @@ static int add_roots_get_min(indexObject
 	int rev, minrev = -1;
 	char *node;
 
-	if (!PySet_Check(roots))
+	if (!PySet_Check(roots)) {
+		PyErr_SetString(PyExc_TypeError,
+		                "roots must be a set of nodes");
 		return -2;
+	}
 	iterator = PyObject_GetIter(roots);
 	if (iterator == NULL)
 		return -2;