# HG changeset patch # User Yuya Nishihara # Date 2016-09-22 09:11:37 # Node ID 2b348dc3239a0d690df2f213343cd9ed5aead92f # Parent 8dee2080f35cc8a84a8bdb400f226823efd3d4c8 dagop: change visit dict of filectxancestors() indexed solely by rev In future patches, a max heap will be used to compute the next revision to visit. diff --git a/mercurial/dagop.py b/mercurial/dagop.py --- a/mercurial/dagop.py +++ b/mercurial/dagop.py @@ -78,6 +78,12 @@ def _walkrevtree(pfunc, revs, startdepth def filectxancestors(fctx, followfirst=False): """Like filectx.ancestors(), but includes the given fctx itself""" visit = {} + def addvisit(fctx): + rev = fctx.rev() + if rev not in visit: + visit[rev] = set() + visit[rev].add(fctx) + c = fctx if followfirst: cut = 1 @@ -87,10 +93,13 @@ def filectxancestors(fctx, followfirst=F yield c while True: for parent in c.parents()[:cut]: - visit[(parent.rev(), parent.filenode())] = parent + addvisit(parent) if not visit: break - c = visit.pop(max(visit)) + rev = max(visit) + c = visit[rev].pop() + if not visit[rev]: + del visit[rev] yield c def _genrevancestors(repo, revs, followfirst, startdepth, stopdepth, cutfunc):