# HG changeset patch # User Augie Fackler # Date 2020-04-02 20:24:34 # Node ID 2db2e9e585b350cc4f604d1010c5068840fff739 # Parent 75f1197db88410af54a55665ff867a2fb8e08a7b manifest: remove a final 40-byte assumption from pure-python parser Differential Revision: https://phab.mercurial-scm.org/D8372 diff --git a/mercurial/manifest.py b/mercurial/manifest.py --- a/mercurial/manifest.py +++ b/mercurial/manifest.py @@ -57,7 +57,12 @@ def _parse(data): raise ValueError(b'Manifest lines not in sorted order.') prev = l f, n = l.split(b'\0') - if len(n) > 40: + nl = len(n) + if 64 < nl: + # modern hash, full width + yield f, bin(n[:64]), n[64:] + if 40 < nl < 45: + # legacy hash, always sha1 yield f, bin(n[:40]), n[40:] else: yield f, bin(n), b'' @@ -265,9 +270,15 @@ class _lazymanifest(object): if pos == -1: return (data[1], data[2]) zeropos = data.find(b'\x00', pos) + nlpos = data.find(b'\n', zeropos) assert 0 <= needle <= len(self.positions) assert len(self.extrainfo) == len(self.positions) - hashval = unhexlify(data, self.extrainfo[needle], zeropos + 1, 40) + hlen = nlpos - zeropos - 1 + # Hashes sometimes have an extra byte tucked on the end, so + # detect that. + if hlen % 2: + hlen -= 1 + hashval = unhexlify(data, self.extrainfo[needle], zeropos + 1, hlen) flags = self._getflags(data, needle, zeropos) return (hashval, flags)