# HG changeset patch # User Augie Fackler # Date 2018-04-25 02:47:14 # Node ID 33817e09c6638b8cd80834efab41c829c5001926 # Parent 32a75a8a5b0f8fc680ab4a5732072df8088c24a1 tests: fix test-check-commit.t when all commits are public I'm 99% sure this is a portable use of /bin/[, and it seems to fix the issue I noticed on the buildbot on my machine. diff --git a/tests/test-check-commit.t b/tests/test-check-commit.t --- a/tests/test-check-commit.t +++ b/tests/test-check-commit.t @@ -8,16 +8,20 @@ Go back in the hg repo $ cd $TESTDIR/.. + $ REVSET='not public() and ::. and not desc("# no-check-commit")' + $ mkdir "$TESTTMP/p" - $ testrepohg export --git -o "$TESTTMP/p/%n-%h" \ - > -r 'not public() and ::. and not desc("# no-check-commit")' - $ for f in `ls "$TESTTMP/p"`; do - > contrib/check-commit < "$TESTTMP/p/$f" > "$TESTTMP/check-commit.out" - > if [ $? -ne 0 ]; then - > node="${f##*-}" - > echo "Revision $node does not comply with rules" - > echo '------------------------------------------------------' - > cat ${TESTTMP}/check-commit.out - > echo - > fi - > done + $ REVS=`testrepohg log -r "$REVSET" -T.` + $ if [ -n "$REVS" ] ; then + > testrepohg export --git -o "$TESTTMP/p/%n-%h" -r "$REVSET" + > for f in `ls "$TESTTMP/p"`; do + > contrib/check-commit < "$TESTTMP/p/$f" > "$TESTTMP/check-commit.out" + > if [ $? -ne 0 ]; then + > node="${f##*-}" + > echo "Revision $node does not comply with rules" + > echo '------------------------------------------------------' + > cat ${TESTTMP}/check-commit.out + > echo + > fi + > done + > fi