# HG changeset patch # User Matt Mackall # Date 2013-04-17 19:38:02 # Node ID 341083b02d1be3fc707f27c360981bb00213dd07 # Parent 48d6f436363e87192988c4f9a60252d1ddd7e4fe check-code: add check for lock release order diff --git a/contrib/check-code.py b/contrib/check-code.py --- a/contrib/check-code.py +++ b/contrib/check-code.py @@ -224,6 +224,7 @@ pypats = [ (r':\n( )*( ){1,3}[^ ]', "must indent 4 spaces"), (r'ui\.(status|progress|write|note|warn)\([\'\"]x', "missing _() in ui message (use () to hide false-positives)"), + (r'release\(.*wlock, .*lock\)', "wrong lock release order"), ], # warnings [