# HG changeset patch # User Anton Shestakov # Date 2023-05-03 21:17:32 # Node ID 392e2f31444a43eec9924f4c6f0ae8da9d5a74d0 # Parent be676c313c7bf18c1e1597c3df53d1d9b797b806 transaction: tr._names are actually bytes, use byte string to join them Looks like this is never checked in the tests? But trying e.g. `print(tr)` by hand before this change would give: TypeError: sequence item 0: expected str instance, bytes found Looks like tr._names are always bytes (although this isn't actually enforced, but maybe at some point it will at least be type checked e.g. by pytype). diff --git a/mercurial/transaction.py b/mercurial/transaction.py --- a/mercurial/transaction.py +++ b/mercurial/transaction.py @@ -314,7 +314,7 @@ class transaction(util.transactional): self._abortcallback = {} def __repr__(self): - name = '/'.join(self._names) + name = b'/'.join(self._names) return '' % ( name, self._count,