# HG changeset patch
# User Sumeet <sumeet@fb.com>
# Date 2012-08-27 19:41:10
# Node ID 3de04c07966a3323a13a2ead46e4b5ce50bf7030
# Parent  e5422a9ffe9d29bde2737775110f4207b24aca27

record: checks for valid username before starting recording process (issue3456)

diff --git a/hgext/record.py b/hgext/record.py
--- a/hgext/record.py
+++ b/hgext/record.py
@@ -496,6 +496,9 @@ def dorecord(ui, repo, commitfunc, cmdsu
         raise util.Abort(_('running non-interactively, use %s instead') %
                          cmdsuggest)
 
+    # make sure username is set before going interactive
+    ui.username()
+
     def recordfunc(ui, repo, message, match, opts):
         """This is generic record driver.
 
diff --git a/tests/test-record.t b/tests/test-record.t
--- a/tests/test-record.t
+++ b/tests/test-record.t
@@ -246,10 +246,19 @@ Add plain file
   +9
   +10
   
+Modify end of plain file with username unset
+
+  $ echo 11 >> plain
+  $ unset HGUSER
+  $ hg record --config ui.username= -d '8 0' -m end plain
+  abort: no username supplied (see "hg help config")
+  [255]
+
 
 Modify end of plain file
 
-  $ echo 11 >> plain
+  $ HGUSER="test"
+  $ export HGUSER
   $ hg record -d '8 0' -m end plain <<EOF
   > y
   > y