# HG changeset patch # User Laurent Charignon # Date 2015-11-18 23:58:06 # Node ID 4223fc58f952cd93592e3cd7302adb11a9136933 # Parent e97132eb841c0c735c1ffdb1f56a1bc29e223d4b rebase: refactoring to avoid repetition of expression This patch removes the repetition of "(revignored, revprecursor, revpruned)" and replaces its occurences with the more legible "revskipped". diff --git a/hgext/rebase.py b/hgext/rebase.py --- a/hgext/rebase.py +++ b/hgext/rebase.py @@ -34,6 +34,7 @@ revignored = -3 revprecursor = -4 # plain prune (no successor) revpruned = -5 +revskipped = (revignored, revprecursor, revpruned) cmdtable = {} command = cmdutil.command(cmdtable) @@ -681,7 +682,7 @@ def defineparents(repo, rev, target, sta elif p1n in state: if state[p1n] == nullmerge: p1 = target - elif state[p1n] in (revignored, revprecursor, revpruned): + elif state[p1n] in revskipped: p1 = nearestrebased(repo, p1n, state) if p1 is None: p1 = target @@ -697,7 +698,7 @@ def defineparents(repo, rev, target, sta if p2n in state: if p1 == target: # p1n in targetancestors or external p1 = state[p2n] - elif state[p2n] in (revignored, revprecursor, revpruned): + elif state[p2n] in revskipped: p2 = nearestrebased(repo, p2n, state) if p2 is None: # no ancestors rebased yet, detach