# HG changeset patch # User Laurent Charignon # Date 2015-07-16 18:17:37 # Node ID 425839c8ec798fa79ad063b0be1d3b0c31f6f2ff # Parent 2cccaf937a7a37de68f50c07cd7190cb53cf947d histedit: minor refactoring of createmarkers check We use a variable to store whether or not we can create obsolescence markers. It makes the patch series more readable as we are going to reuse this values in other places in the function. diff --git a/hgext/histedit.py b/hgext/histedit.py --- a/hgext/histedit.py +++ b/hgext/histedit.py @@ -750,6 +750,7 @@ def _histedit(ui, repo, state, *freeargs replacements = [] state.keep = opts.get('keep', False) + supportsmarkers = obsolete.isenabled(repo, obsolete.createmarkersopt) # rebuild state if goal == 'continue': @@ -881,7 +882,7 @@ def _histedit(ui, repo, state, *freeargs if mapping: movebookmarks(ui, repo, mapping, state.topmost, ntm) # TODO update mq state - if obsolete.isenabled(repo, obsolete.createmarkersopt): + if supportsmarkers: markers = [] # sort by revision number because it sound "right" for prec in sorted(mapping, key=repo.changelog.rev):