# HG changeset patch # User Yuya Nishihara # Date 2017-04-02 02:54:24 # Node ID 47925b63be702fc9b7cd7e2f872823127b77d4b0 # Parent 8d9eafe011110430cd11cf836fae6039eda389c4 templatefilters: use list comprehension in json() Not important, but the code slightly looks better. diff --git a/mercurial/templatefilters.py b/mercurial/templatefilters.py --- a/mercurial/templatefilters.py +++ b/mercurial/templatefilters.py @@ -230,15 +230,11 @@ def json(obj): elif isinstance(obj, str): return '"%s"' % encoding.jsonescape(obj, paranoid=True) elif util.safehasattr(obj, 'keys'): - out = [] - for k, v in sorted(obj.iteritems()): - s = '%s: %s' % (json(k), json(v)) - out.append(s) + out = ['%s: %s' % (json(k), json(v)) + for k, v in sorted(obj.iteritems())] return '{' + ', '.join(out) + '}' elif util.safehasattr(obj, '__iter__'): - out = [] - for i in obj: - out.append(json(i)) + out = [json(i) for i in obj] return '[' + ', '.join(out) + ']' else: raise TypeError('cannot encode type %s' % obj.__class__.__name__)