# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 2020-02-20 15:56:40
# Node ID 4ce2330f2d0b9690cc852602a9e055491a408c03
# Parent  66a05dbb8b4c9898d777757e2713f8952dc5f58f

phabricator: also check parent fctx for binary where it is checked for UTF-8

I don't know that this is necessary, but it seems obvious from the code checking
both the current and parent file for UTF-8 content that this was the intent.

Differential Revision: https://phab.mercurial-scm.org/D8221

diff --git a/hgext/phabricator.py b/hgext/phabricator.py
--- a/hgext/phabricator.py
+++ b/hgext/phabricator.py
@@ -831,7 +831,12 @@ def addmodified(pdiff, ctx, modified):
             pchange.addoldmode(originalmode)
             pchange.addnewmode(filemode)
 
-        if fctx.isbinary() or notutf8(fctx) or notutf8(oldfctx):
+        if (
+            fctx.isbinary()
+            or notutf8(fctx)
+            or oldfctx.isbinary()
+            or notutf8(oldfctx)
+        ):
             makebinary(pchange, fctx)
             addoldbinary(pchange, fctx.p1(), fctx)
         else:
@@ -892,7 +897,11 @@ def addadded(pdiff, ctx, added, removed)
             pchange.addnewmode(gitmode[fctx.flags()])
             pchange.type = DiffChangeType.ADD
 
-        if fctx.isbinary() or notutf8(fctx) or (oldfctx and notutf8(oldfctx)):
+        if (
+            fctx.isbinary()
+            or notutf8(fctx)
+            or (oldfctx and (oldfctx.isbinary() or notutf8(oldfctx)))
+        ):
             makebinary(pchange, fctx)
             if renamed:
                 addoldbinary(pchange, oldfctx, fctx)