# HG changeset patch # User Martin von Zweigbergk # Date 2018-10-18 17:11:08 # Node ID 4f37af86d5d51cdf773b1314b703992622e19b02 # Parent 0a212b643277a05a8be9dd3a13d6f2f5f0f4dbe6 debugcommands: avoid stack trace from debugindexstats in pure mode This has been broken since I added it in d71e0ba34d9b (debugcommands: add a debugindexstats command, 2018-08-08). This patch also fixes the test. Differential Revision: https://phab.mercurial-scm.org/D5152 diff --git a/mercurial/debugcommands.py b/mercurial/debugcommands.py --- a/mercurial/debugcommands.py +++ b/mercurial/debugcommands.py @@ -1168,7 +1168,10 @@ def debugindexdot(ui, repo, file_=None, def debugindexstats(ui, repo): """show stats related to the changelog index""" repo.changelog.shortest(nullid, 1) - for k, v in sorted(repo.changelog.index.stats().items()): + index = repo.changelog.index + if not util.safehasattr(index, 'stats'): + raise error.Abort(_('debugindexstats only works with native code')) + for k, v in sorted(index.stats().items()): ui.write('%s: %s\n' % (k, v)) @command('debuginstall', [] + cmdutil.formatteropts, '', norepo=True) diff --git a/tests/test-debugcommands.t b/tests/test-debugcommands.t --- a/tests/test-debugcommands.t +++ b/tests/test-debugcommands.t @@ -176,7 +176,12 @@ Test debugindex, with and without the -- debugdelta chain basic output -#if reporevlogstore +#if reporevlogstore pure + $ hg debugindexstats + abort: debugindexstats only works with native code + [255] +#endif +#if reporevlogstore no-pure $ hg debugindexstats node trie capacity: 4 node trie count: 2 @@ -186,7 +191,9 @@ debugdelta chain basic output node trie misses: 1 node trie splits: 1 revs in memory: 3 +#endif +#if reporevlogstore no-pure $ hg debugdeltachain -m rev chain# chainlen prev delta size rawsize chainsize ratio lindist extradist extraratio 0 1 1 -1 base 44 43 44 1.02326 44 0 0.00000