# HG changeset patch # User Augie Fackler # Date 2017-10-15 04:41:34 # Node ID 5a9cad0dfddb8360f2e10a7c3bd8544dfcdd7a5b # Parent 60143d038eb7beb1b153a49317c2cd14f0ad9873 hgweb: when unpacking args from request form, convert to bytes We assume http-originated values are ASCII, which should be safe based on the RFC. Differential Revision: https://phab.mercurial-scm.org/D1110 diff --git a/mercurial/hgweb/protocol.py b/mercurial/hgweb/protocol.py --- a/mercurial/hgweb/protocol.py +++ b/mercurial/hgweb/protocol.py @@ -16,6 +16,7 @@ from .common import ( from .. import ( error, + pycompat, util, wireproto, ) @@ -65,6 +66,9 @@ class webproto(wireproto.abstractserverp return [data[k] for k in keys] def _args(self): args = self.req.form.copy() + if pycompat.ispy3: + args = {k.encode('ascii'): [v.encode('ascii') for v in vs] + for k, vs in args.items()} postlen = int(self.req.env.get('HTTP_X_HGARGS_POST', 0)) if postlen: args.update(cgi.parse_qs(