# HG changeset patch
# User Jun Wu <quark@fb.com>
# Date 2017-03-08 21:34:25
# Node ID 68c94f286e2574e6f5ebc1e72acb3e2929db94aa
# Parent  51934fc796c038a12c6b7ca6d92fdfa9f29ff0ea

chg: document why we send SIGHUP and SIGINT to process group

This makes the code more consistent - other signals are documented.

diff --git a/contrib/chg/procutil.c b/contrib/chg/procutil.c
--- a/contrib/chg/procutil.c
+++ b/contrib/chg/procutil.c
@@ -91,11 +91,15 @@ void setupsignalhandler(pid_t pid, pid_t
 
 	struct sigaction sa;
 	memset(&sa, 0, sizeof(sa));
+
+	/* deadly signals meant to be sent to a process group:
+	 * - SIGHUP: usually generated by the kernel, when termination of a
+	 *   process causes that process group to become orphaned
+	 * - SIGINT: usually generated by the terminal */
 	sa.sa_handler = forwardsignaltogroup;
 	sa.sa_flags = SA_RESTART;
 	if (sigemptyset(&sa.sa_mask) < 0)
 		goto error;
-
 	if (sigaction(SIGHUP, &sa, NULL) < 0)
 		goto error;
 	if (sigaction(SIGINT, &sa, NULL) < 0)