# HG changeset patch # User FUJIWARA Katsunori # Date 2015-07-14 18:43:16 # Node ID 69145daacdfa24bc765723b962634c5026ac68b5 # Parent 902148444889d2f7a8aec43726893c45e64ce7b8 cmdutil: allow callers of cmdutil.dorecord to omit suggestion Interactive committing under non-interactive mode shows command suggestion, but sometimes it is meaningless. command suggestion usability ------------ ---------- ----------- record commit commit -i commit meaningless qrecord qnew qnew -i qnew meaningless qrefersh -i qrefresh meaningless shelve -i commit incorrect ------------ ---------- ----------- This patch allows callers of 'cmdutil.dorecord()' to omit meaningless suggestion by passing None or so for 'cmdsuggest' argument of it. This is a preparation for subsequent patches, which fix each suggestion issues above. diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py --- a/mercurial/cmdutil.py +++ b/mercurial/cmdutil.py @@ -81,8 +81,11 @@ def dorecord(ui, repo, commitfunc, cmdsu import merge as mergemod if not ui.interactive(): - raise util.Abort(_('running non-interactively, use %s instead') % - cmdsuggest) + if cmdsuggest: + msg = _('running non-interactively, use %s instead') % cmdsuggest + else: + msg = _('running non-interactively') + raise util.Abort(msg) # make sure username is set before going interactive if not opts.get('user'):