# HG changeset patch
# User Martin von Zweigbergk <martinvonz@google.com>
# Date 2017-07-01 06:58:59
# Node ID 69c4493a54f9811233204613095849985ee021f8
# Parent  248d5890c80a6a6c42d8e8d2132395eb5868c6b8

changegroup: don't fail on empty changegroup (API)

I don't know why applying an empty changegroup should be an error. It
seems harmless. I suspect the check was there to find code that
creates empty changegroups just because that would be wasteful. Let's
use develwarn() for that instead, so we catch any such cases that run
with our test runner, but we still allow others to generate empty
changegroups if they want to.

We have run into this check at Google once or twice and had to work
around it, but I'm changing this not so much because of that, but
because it seems like it shouldn't be an error.

I also changed the message slightly to be more modern ("changelog
group" -> "changegroup") and more generic ("received" -> "applied").

diff --git a/mercurial/changegroup.py b/mercurial/changegroup.py
--- a/mercurial/changegroup.py
+++ b/mercurial/changegroup.py
@@ -298,7 +298,8 @@ class cg1unpacker(object):
             efiles = len(efiles)
 
             if not cgnodes:
-                raise error.Abort(_("received changelog group is empty"))
+                repo.ui.develwarn('applied empty changegroup',
+                                  config='empty-changegroup')
             clend = len(cl)
             changesets = clend - clstart
             repo.ui.progress(_('changesets'), None)