# HG changeset patch
# User Martin von Zweigbergk <martinvonz@google.com>
# Date 2020-01-09 23:41:40
# Node ID 6cfaebb625d3310316cbe080bc32893836889efc
# Parent  de5d34ca01bd9cb6357d95d13a4e430215a80245

grep: speed up `hg grep --all-files some/path` by using ctx.matches(match)

ctx.matches(match) avoids walking unintersting parts of the tree when
using tree manifests. That can make a very big difference when
grepping in a small subset of the tree (2.0s -> 0.7s in my case, but
can of course be made more extreme by picking a smaller subset of
files).

Differential Revision: https://phab.mercurial-scm.org/D7820

diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py
--- a/mercurial/cmdutil.py
+++ b/mercurial/cmdutil.py
@@ -2429,12 +2429,16 @@ def walkchangerevs(repo, match, opts, pr
 
                     def fns_generator():
                         if allfiles:
-                            fiter = iter(ctx)
+
+                            def bad(f, msg):
+                                pass
+
+                            for f in ctx.matches(matchmod.badmatch(match, bad)):
+                                yield f
                         else:
-                            fiter = ctx.files()
-                        for f in fiter:
-                            if match(f):
-                                yield f
+                            for f in ctx.files():
+                                if match(f):
+                                    yield f
 
                     fns = fns_generator()
                 prepare(ctx, fns)