# HG changeset patch # User anatoly techtonik # Date 2014-07-26 06:27:11 # Node ID 6dfb78f18bdba03067c7060cbe5b4ca2e757dde9 # Parent 838025b15925695bfcf15ad1c3e2b975c85d9aec config: allow 'user' in .hgrc ui section (issue3169) diff --git a/mercurial/ui.py b/mercurial/ui.py --- a/mercurial/ui.py +++ b/mercurial/ui.py @@ -437,7 +437,7 @@ class ui(object): """ user = os.environ.get("HGUSER") if user is None: - user = self.config("ui", "username") + user = self.config("ui", ["username", "user"]) if user is not None: user = os.path.expandvars(user) if user is None: diff --git a/tests/test-committer.t b/tests/test-committer.t --- a/tests/test-committer.t +++ b/tests/test-committer.t @@ -52,15 +52,34 @@ abort: no username supplied (use "hg config --edit" to set your username) [255] + +# test alternate config var + + $ echo 1234 > asdf + $ echo "[ui]" > .hg/hgrc + $ echo "user = Foo Bar II " >> .hg/hgrc + $ hg commit -m commit-1 + $ hg tip + changeset: 4:6f24bfb4c617 + tag: tip + user: Foo Bar II + date: Thu Jan 01 00:00:00 1970 +0000 + summary: commit-1 + +# test no .hg/hgrc (uses generated non-interactive username) + + $ echo space > asdf $ rm .hg/hgrc $ hg commit -m commit-1 2>&1 no username found, using '[^']*' instead (re) - $ echo space > asdf + $ echo space2 > asdf $ hg commit -u ' ' -m commit-1 transaction abort! rollback completed abort: empty username! [255] +# don't add tests here, previous test is unstable + $ cd ..