# HG changeset patch
# User Matt Mackall <mpm@selenic.com>
# Date 2014-04-11 19:38:18
# Node ID 70312c95f2f7ac681085be54489faebebc241146
# Parent  7a679918ee2b8fcb7e15179b7f072c8ef69315b4

subrepo: check return code for git push (issue4223)

diff --git a/mercurial/subrepo.py b/mercurial/subrepo.py
--- a/mercurial/subrepo.py
+++ b/mercurial/subrepo.py
@@ -1463,8 +1463,8 @@ class gitsubrepo(abstractsubrepo):
                 return False
             self._ui.status(_('pushing branch %s of subrepo %s\n') %
                             (current.split('/', 2)[2], self._relpath))
-            self._gitcommand(cmd + ['origin', current])
-            return True
+            ret = self._gitdir(cmd + ['origin', current])
+            return ret[1] == 0
         else:
             self._ui.warn(_('no branch checked out in subrepo %s\n'
                             'cannot push revision %s\n') %