# HG changeset patch # User Gregory Szorc # Date 2017-05-06 18:12:23 # Node ID 73c3e226d2fc29af8490180f68193941b9279aed # Parent 75e93d95aae66b02413f5793dada1763c8091408 perf: don't convert rev to node before calling revlog.revision() diff --git a/contrib/perf.py b/contrib/perf.py --- a/contrib/perf.py +++ b/contrib/perf.py @@ -864,7 +864,7 @@ def perfrevlog(ui, repo, file_=None, sta dist = -1 * dist for x in xrange(beginrev, endrev, dist): - r.revision(r.node(x)) + r.revision(x) timer, fm = gettimer(ui, opts) timer(d) diff --git a/tests/test-check-code.t b/tests/test-check-code.t --- a/tests/test-check-code.t +++ b/tests/test-check-code.t @@ -9,15 +9,11 @@ New errors are not allowed. Warnings are $ hg locate -X contrib/python-zstandard -X hgext/fsmonitor/pywatchman | > sed 's-\\-/-g' | "$check_code" --warnings --per-file=0 - || false - contrib/perf.py:867: - > r.revision(r.node(x)) - don't convert rev to node before passing to revision(nodeorrev) Skipping i18n/polib.py it has no-che?k-code (glob) Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob) Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob) Skipping mercurial/statprof.py it has no-che?k-code (glob) Skipping tests/badserverext.py it has no-che?k-code (glob) - [1] @commands in debugcommands.py should be in alphabetical order. diff --git a/tests/test-contrib-perf.t b/tests/test-contrib-perf.t --- a/tests/test-contrib-perf.t +++ b/tests/test-contrib-perf.t @@ -165,7 +165,3 @@ Check perf.py for historical portability $ (hg files -r 1.2 glob:mercurial/*.c glob:mercurial/*.py; > hg files -r tip glob:mercurial/*.c glob:mercurial/*.py) | > "$TESTDIR"/check-perf-code.py contrib/perf.py - contrib/perf.py:867: - > r.revision(r.node(x)) - don't convert rev to node before passing to revision(nodeorrev) - [1]