# HG changeset patch # User Gregory Szorc # Date 2018-01-11 03:36:45 # Node ID 74bec9e74831fc4c1474967fa017e4b2a17c84fc # Parent 11c86ab69e670a0853c337c11c496e10da254dd1 rust: add TODO about lifetime of program_name variable Per review comment in D1581. Differential Revision: https://phab.mercurial-scm.org/D1847 diff --git a/rust/hgcli/src/main.rs b/rust/hgcli/src/main.rs --- a/rust/hgcli/src/main.rs +++ b/rust/hgcli/src/main.rs @@ -125,6 +125,9 @@ fn run() -> Result<(), i32> { // Set program name. The backing memory needs to live for the duration of the // interpreter. // + // TODO consider storing this in a static or associating with lifetime of + // the Python interpreter. + // // Yes, we use the path to the Python interpreter not argv[0] here. The // reason is because Python uses the given path to find the location of // Python files. Apparently we could define our own ``Py_GetPath()``