# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@octobus.net>
# Date 2021-07-10 11:46:35
# Node ID 752109dc2fb757bc86af32e88eb756135963a89d
# Parent  352ada3aab70f403bdd3980e587e594a2c6dc389

check-code: add a rules to catch os.path.abspath

All previous usages have been migrated. So let us add a check-code rules to
catch future usages.

We restrict it to mercurial/ and hgext/ because multiple other script never
depends on Mercurial modules.

Differential Revision: https://phab.mercurial-scm.org/D11072

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -545,6 +545,22 @@ commonpyfilters = [
     ),
 ]
 
+# pattern only for mercurial and extensions
+core_py_pats = [
+    [
+        # Windows tend to get confused about capitalization of the drive letter
+        #
+        # see mercurial.windows.abspath for details
+        (
+            r'os\.path\.abspath',
+            "use util.abspath instead (windows)",
+            r'#.*re-exports',
+        ),
+    ],
+    # warnings
+    [],
+]
+
 # filters to convert normal *.py files
 pyfilters = [] + commonpyfilters
 
@@ -700,6 +716,13 @@ checks = [
         pyfilters,
         py3pats,
     ),
+    (
+        'core files',
+        r'.*(hgext|mercurial)/(?!demandimport|policy|pycompat).*\.py',
+        '',
+        pyfilters,
+        core_py_pats,
+    ),
     ('test script', r'(.*/)?test-[^.~]*$', '', testfilters, testpats),
     ('c', r'.*\.[ch]$', '', cfilters, cpats),
     ('unified test', r'.*\.t$', '', utestfilters, utestpats),