# HG changeset patch # User Pierre-Yves David # Date 2023-02-02 16:20:46 # Node ID 7b0cc86c5d7451815200057440cc188d8c487f11 # Parent b0e3f1508a25da9ad1f803a5f5d133cedae0a33c safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage. diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py --- a/mercurial/cmdutil.py +++ b/mercurial/cmdutil.py @@ -1450,7 +1450,7 @@ def openstorage(repo, cmd, file_, opts, if returnrevlog: if isinstance(r, revlog.revlog): pass - elif util.safehasattr(r, b'_revlog'): + elif util.safehasattr(r, '_revlog'): r = r._revlog # pytype: disable=attribute-error elif r is not None: raise error.InputError(