# HG changeset patch # User Pulkit Goyal <7895pulkit@gmail.com> # Date 2016-06-27 10:46:10 # Node ID 80880ad3fccd370d361a0c77655fe36b9db40d4c # Parent 72065b3b90a44ce6fe64e8054c0e1128b1e4d3b7 py3: conditionalize the urlparse import The urlparse library is renamed to urllib.parse in python 3 diff --git a/hgext/bugzilla.py b/hgext/bugzilla.py --- a/hgext/bugzilla.py +++ b/hgext/bugzilla.py @@ -281,7 +281,6 @@ from __future__ import absolute_import import re import time -import urlparse import xmlrpclib from mercurial.i18n import _ @@ -293,6 +292,8 @@ from mercurial import ( util, ) +urlparse = util.urlparse + # Note for extension authors: ONLY specify testedwith = 'internal' for # extensions which SHIP WITH MERCURIAL. Non-mainline extensions should # be specifying the version(s) of Mercurial they are tested with, or diff --git a/mercurial/pycompat.py b/mercurial/pycompat.py --- a/mercurial/pycompat.py +++ b/mercurial/pycompat.py @@ -18,6 +18,13 @@ except ImportError: pickle.dumps # silence pyflakes try: + import urlparse + urlparse.urlparse +except ImportError: + import urllib.parse as urlparse + urlparse.urlparse + +try: import cStringIO as io stringio = io.StringIO except ImportError: diff --git a/mercurial/util.py b/mercurial/util.py --- a/mercurial/util.py +++ b/mercurial/util.py @@ -50,6 +50,7 @@ for attr in ( 'pickle', 'queue', 'urlerr', + 'urlparse', # we do import urlreq, but we do it outside the loop #'urlreq', 'stringio', diff --git a/tests/test-check-py3-compat.t b/tests/test-check-py3-compat.t --- a/tests/test-check-py3-compat.t +++ b/tests/test-check-py3-compat.t @@ -26,7 +26,7 @@ doc/hgmanpage.py: invalid syntax: invalid syntax (, line *) (glob) hgext/automv.py: error importing module: invalid syntax (commands.py, line *) (line *) (glob) hgext/blackbox.py: error importing: 'dict' object has no attribute 'iteritems' (error at revset.py:*) (glob) - hgext/bugzilla.py: error importing module: No module named 'urlparse' (line *) (glob) + hgext/bugzilla.py: error importing module: No module named 'xmlrpclib' (line *) (glob) hgext/censor.py: error importing: 'dict' object has no attribute 'iteritems' (error at revset.py:*) (glob) hgext/chgserver.py: error importing module: No module named 'SocketServer' (line *) (glob) hgext/children.py: error importing: 'dict' object has no attribute 'iteritems' (error at revset.py:*) (glob) diff --git a/tests/tinyproxy.py b/tests/tinyproxy.py --- a/tests/tinyproxy.py +++ b/tests/tinyproxy.py @@ -20,7 +20,10 @@ import os import select import socket import sys -import urlparse + +from mercurial import util + +urlparse = util.urlparse class ProxyHandler (BaseHTTPServer.BaseHTTPRequestHandler): __base = BaseHTTPServer.BaseHTTPRequestHandler