# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@octobus.net>
# Date 2020-03-12 14:23:47
# Node ID 864e9534d3d4f984e9c50a40e812e844816847bc
# Parent  daf083140b5b8a95b8388a3e4844f7ef259b2391

cext-index: propagate inline_scan error in `index_deref`

Before this change, revlog index corruption could be silently ignored in some
situation.

Differential Revision: https://phab.mercurial-scm.org/D8276

diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
--- a/mercurial/cext/revlog.c
+++ b/mercurial/cext/revlog.c
@@ -157,7 +157,10 @@ static const char *index_deref(indexObje
 			                             sizeof(*self->offsets));
 			if (self->offsets == NULL)
 				return (const char *)PyErr_NoMemory();
-			inline_scan(self, self->offsets);
+			Py_ssize_t ret = inline_scan(self, self->offsets);
+			if (ret == -1) {
+				return NULL;
+			};
 		}
 		return self->offsets[pos];
 	}