# HG changeset patch # User Pierre-Yves David # Date 2023-02-02 16:35:38 # Node ID 921a72735482e30f574f7af09a2a6cc538b3913f # Parent 80b37d26097f9009a666e1c7906331d7619435f4 safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage. diff --git a/mercurial/smartset.py b/mercurial/smartset.py --- a/mercurial/smartset.py +++ b/mercurial/smartset.py @@ -670,7 +670,7 @@ class addset(abstractsmartset): if self._ascending: attr = 'fastasc' else: - attr = b'fastdesc' + attr = 'fastdesc' it = getattr(self, attr) if it is not None: return it()