# HG changeset patch # User Pierre-Yves David # Date 2017-04-09 16:12:54 # Node ID 9bd9e9cb3f69d83be55a55a91519d65ad1593bb7 # Parent 6d055cd6669f771e815cc11dd9d8522f6ef3ba73 bundle2: clarify the docstring of unpackermixin methods The unpackermixin is a utility used to implement the bundle2 protocol. It should not be used when writing part handlers. We update the docstring to clarify this. diff --git a/mercurial/bundle2.py b/mercurial/bundle2.py --- a/mercurial/bundle2.py +++ b/mercurial/bundle2.py @@ -621,12 +621,24 @@ class unpackermixin(object): util.safehasattr(fp, 'tell')) def _unpack(self, format): - """unpack this struct format from the stream""" + """unpack this struct format from the stream + + This method is meant for internal usage by the bundle2 protocol only. + They directly manipulate the low level stream including bundle2 level + instruction. + + Do not use it to implement higher-level logic or methods.""" data = self._readexact(struct.calcsize(format)) return _unpack(format, data) def _readexact(self, size): - """read exactly bytes from the stream""" + """read exactly bytes from the stream + + This method is meant for internal usage by the bundle2 protocol only. + They directly manipulate the low level stream including bundle2 level + instruction. + + Do not use it to implement higher-level logic or methods.""" return changegroup.readexactly(self._fp, size) def seek(self, offset, whence=0):