# HG changeset patch # User Matt Harbison # Date 2019-04-06 02:47:45 # Node ID 9c07d345fd6da92c16ee0e809202efcfa3e5cbe9 # Parent 16692aa3472b321da55f209827f70d150cc5eee8 packaging: don't crash building wix with python3.6 and earlier `capture_output` was added in 3.7. I was tempted to just check and abort in build.py, since Windows doesn't have the Linux problem where some distros only ship an older python. But this is in a library that could be used elsewhere in the future. diff --git a/contrib/packaging/hgpackaging/util.py b/contrib/packaging/hgpackaging/util.py --- a/contrib/packaging/hgpackaging/util.py +++ b/contrib/packaging/hgpackaging/util.py @@ -142,11 +142,9 @@ import platform; print("%s:%s" % (platfo def python_exe_info(python_exe: pathlib.Path): """Obtain information about a Python executable.""" - res = subprocess.run( - [str(python_exe), '-c', PRINT_PYTHON_INFO], - capture_output=True, check=True) + res = subprocess.check_output([str(python_exe), '-c', PRINT_PYTHON_INFO]) - arch, version = res.stdout.decode('utf-8').split(':') + arch, version = res.decode('utf-8').split(':') version = distutils.version.LooseVersion(version)