# HG changeset patch # User Matt Mackall # Date 2012-01-19 17:35:06 # Node ID 9d4b5c3cb85304234c31b98b821c7ebf54418360 # Parent b8696a6676bed4bea1b0da76cbee21a22ba886d6 qimport: back out 2eec74d7ce95 This patch presumed mq csets must always be secret, which isn't yet established. diff --git a/hgext/mq.py b/hgext/mq.py --- a/hgext/mq.py +++ b/hgext/mq.py @@ -1814,9 +1814,6 @@ class queue(object): self.added.append(patchname) patchname = None - if rev: - # if we added anything with rev, we must move the secret root - phases.retractboundary(repo, phases.secret, [n]) self.parseseries() self.applieddirty = True self.seriesdirty = True @@ -1991,21 +1988,16 @@ def qimport(ui, repo, *filename, **opts) Returns 0 if import succeeded. """ - lock = repo.lock() # cause this may move phase + q = repo.mq try: - q = repo.mq - try: - q.qimport(repo, filename, patchname=opts.get('name'), - existing=opts.get('existing'), force=opts.get('force'), - rev=opts.get('rev'), git=opts.get('git')) - finally: - q.savedirty() - - - if opts.get('push') and not opts.get('rev'): - return q.push(repo, None) + q.qimport(repo, filename, patchname=opts.get('name'), + existing=opts.get('existing'), force=opts.get('force'), + rev=opts.get('rev'), git=opts.get('git')) finally: - lock.release() + q.savedirty() + + if opts.get('push') and not opts.get('rev'): + return q.push(repo, None) return 0 def qinit(ui, repo, create): diff --git a/tests/test-mq-qimport.t b/tests/test-mq-qimport.t --- a/tests/test-mq-qimport.t +++ b/tests/test-mq-qimport.t @@ -165,8 +165,6 @@ try to import --push patch b.diff finalized without changeset message patch another.diff finalized without changeset message $ hg qimport -rtip -P - $ hg phase -r qbase - 2: secret $ hg qpop -a popping 2.diff patch queue now empty