# HG changeset patch # User Raphaël Gomès # Date 2022-04-05 08:55:28 # Node ID 9dcfd1d05e6ea0a0c3d74c331282d93c48c12042 # Parent ce919b1a1063a7826b635ad24aeb73a68d09cbc7 rust-hgpath: add `repr(transparent)` to `HgPath` It's been stabilized a long time ago, so let's not rely on an implementation detail now. Differential Revision: https://phab.mercurial-scm.org/D12433 diff --git a/rust/hg-core/src/utils/hg_path.rs b/rust/hg-core/src/utils/hg_path.rs --- a/rust/hg-core/src/utils/hg_path.rs +++ b/rust/hg-core/src/utils/hg_path.rs @@ -144,15 +144,8 @@ impl From for std::io::Erro /// On Unix, it's just byte-to-byte conversion. On Windows, it has to be /// decoded from MBCS to WTF-8. If WindowsUTF8Plan is implemented, the source /// character encoding will be determined on a per-repository basis. -// -// FIXME: (adapted from a comment in the stdlib) -// `HgPath::new()` current implementation relies on `Slice` being -// layout-compatible with `[u8]`. -// When attribute privacy is implemented, `Slice` should be annotated as -// `#[repr(transparent)]`. -// Anyway, `Slice` representation and layout are considered implementation -// detail, are not documented and must not be relied upon. #[derive(Eq, Ord, PartialEq, PartialOrd, Hash)] +#[repr(transparent)] pub struct HgPath { inner: [u8], }