# HG changeset patch
# User Na'Tosha Bard <natosha@unity3d.com>
# Date 2012-03-09 15:45:49
# Node ID a18ad914aa21fefd0182b164f69e726ca7b31d15
# Parent  60cc3a0d224972e0fca00fe93f0488b5e4a60c7c

largefiles: move calculation of largefiles for updating to utility function

diff --git a/hgext/largefiles/lfutil.py b/hgext/largefiles/lfutil.py
--- a/hgext/largefiles/lfutil.py
+++ b/hgext/largefiles/lfutil.py
@@ -457,3 +457,11 @@ def getstandinsstate(repo):
         lfile = splitstandin(standin)
         standins.append((lfile, readstandin(repo, lfile)))
     return standins
+
+def getlfilestoupdate(oldstandins, newstandins):
+    changedstandins = set(oldstandins).symmetric_difference(set(newstandins))
+    filelist = []
+    for f in changedstandins:
+        if f[0] not in filelist:
+            filelist.append(f[0])
+    return filelist
diff --git a/hgext/largefiles/overrides.py b/hgext/largefiles/overrides.py
--- a/hgext/largefiles/overrides.py
+++ b/hgext/largefiles/overrides.py
@@ -602,19 +602,11 @@ def override_revert(orig, ui, repo, *pat
         wlock.release()
 
 def hg_update(orig, repo, node):
-    # In order to not waste a lot of extra time during the update largefiles
-    # step, we keep track of the state of the standins before and after we
-    # call the original update function, and only update the standins that
-    # have changed in the hg.update() call
+    # Only call updatelfiles the standins that have changed to save time
     oldstandins = lfutil.getstandinsstate(repo)
     result = orig(repo, node)
     newstandins = lfutil.getstandinsstate(repo)
-    tobeupdated = set(oldstandins).symmetric_difference(set(newstandins))
-    filelist = []
-    for f in tobeupdated:
-        if f[0] not in filelist:
-            filelist.append(f[0])
-
+    filelist = lfutil.getlfilestoupdate(oldstandins, newstandins)
     lfcommands.updatelfiles(repo.ui, repo, filelist=filelist, printmessage=True)
     return result