# HG changeset patch # User Boris Feld # Date 2017-07-10 15:48:33 # Node ID a3acacbd0ff36a58a0b52d8defb8cea9ef782ed7 # Parent d09de637cbc88ed2db989298115d0c0cb6cc6f27 bookmark: remove a useless 'recordchange' in the amend code We do not touch the bookmarks store in this code, just the active bookmark, not covered by the transaction. So it seems we can safely drop this call and the tests agree with us. diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py --- a/mercurial/cmdutil.py +++ b/mercurial/cmdutil.py @@ -2750,7 +2750,7 @@ def amend(ui, repo, commitfunc, old, ext base = old.p1() newid = None - with repo.wlock(), repo.lock(), repo.transaction('amend') as tr: + with repo.wlock(), repo.lock(), repo.transaction('amend'): # See if we got a message from -m or -l, if not, open the editor # with the message of the changeset to amend message = logmessage(ui, opts) @@ -2768,7 +2768,6 @@ def amend(ui, repo, commitfunc, old, ext node = commit(ui, repo, commitfunc, pats, opts) finally: repo._bookmarks.active = activebookmark - repo._bookmarks.recordchange(tr) ui.callhooks = True ctx = repo[node]