# HG changeset patch # User Gregory Szorc # Date 2018-08-10 19:08:45 # Node ID a79279a21b0a1812318a34e5f58d52d24232d47d # Parent 43387fd2aa1f63524ef0a1656570edf66e9651ca changegroup: call rev() on manifestlog instance rev() is part of the imanifestlog interface and should be used instead of using the private revlog instance, which is an implementation detail. Differential Revision: https://phab.mercurial-scm.org/D4269 diff --git a/mercurial/changegroup.py b/mercurial/changegroup.py --- a/mercurial/changegroup.py +++ b/mercurial/changegroup.py @@ -946,8 +946,6 @@ class cgpacker(object): clrevorder = {} mfs = {} # needed manifests mfl = self._repo.manifestlog - # TODO violates storage abstraction. - mfrevlog = mfl._revlog changedfiles = set() clrevtomanifestrev = {} @@ -973,7 +971,7 @@ class cgpacker(object): # manifest revnum to look up for this cl revnum. (Part of # mapping changelog ellipsis parents to manifest ellipsis # parents) - clrevtomanifestrev.setdefault(cl.rev(x), mfrevlog.rev(n)) + clrevtomanifestrev.setdefault(cl.rev(x), mfl.rev(n)) # We can't trust the changed files list in the changeset if the # client requested a shallow clone. if self._isshallow: