# HG changeset patch # User Simon Heimberg # Date 2013-03-09 21:14:46 # Node ID a91387a37f05d24855a3ab13af1112d63bb23620 # Parent 8cc8715b36030fc84f17426cc384155eb743a5f7 check-code: do not prepend "warning" to a failure message The prefix has not been removed when this check changed from a warning to a failure. diff --git a/contrib/check-code.py b/contrib/check-code.py --- a/contrib/check-code.py +++ b/contrib/check-code.py @@ -216,7 +216,7 @@ pypats = [ (r'(?i)descendent', "the proper spelling is descendAnt"), (r'\.debug\(\_', "don't mark debug messages for translation"), (r'\.strip\(\)\.split\(\)', "no need to strip before splitting"), - (r'^\s*except\s*:', "warning: naked except clause", r'#.*re-raises'), + (r'^\s*except\s*:', "naked except clause", r'#.*re-raises'), (r':\n( )*( ){1,3}[^ ]', "must indent 4 spaces"), (r'ui\.(status|progress|write|note|warn)\([\'\"]x', "missing _() in ui message (use () to hide false-positives)"), diff --git a/tests/test-check-code.t b/tests/test-check-code.t --- a/tests/test-check-code.t +++ b/tests/test-check-code.t @@ -163,13 +163,13 @@ object comparison with literal [1] - $ cat > warning.py < for-nolineno.py < except: > EOF - $ "$check_code" warning.py --warning --nolineno - warning.py:0: + $ "$check_code" for-nolineno.py --nolineno + for-nolineno.py:0: > except: - warning: naked except clause + naked except clause [1] $ cat > raise-format.py <